Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

New: Class implements generic syntax (fixes #44) #53

Merged
merged 1 commit into from
Aug 10, 2016
Merged

New: Class implements generic syntax (fixes #44) #53

merged 1 commit into from
Aug 10, 2016

Conversation

JamesHenry
Copy link
Member

No description provided.

@eslintbot
Copy link

LGTM

@JamesHenry JamesHenry mentioned this pull request Aug 9, 2016
Closed
@nzakas
Copy link
Member

nzakas commented Aug 10, 2016

This looks good. I'm assuming it still needs to be updated to ignore the leading whitespace in the location information?

@JamesHenry
Copy link
Member Author

No, that is in this PR :) https://github.com/JamesHenry/typescript-eslint-parser/blob/e2f854539e2fd50f9bae5b88d1a625d6c016cf76/lib/ast-converter.js#L472

@JamesHenry
Copy link
Member Author

And in the tokens: [] you can see the , Punctuator ends on 27, but the T Identifier doesn't start until 28

@nzakas
Copy link
Member

nzakas commented Aug 10, 2016

Cool! In that case, this looks ready to go.

@nzakas nzakas merged commit 62d14b4 into eslint:master Aug 10, 2016
@JamesHenry JamesHenry deleted the issue-44 branch August 10, 2016 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA: Valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesHenry @eslintbot @nzakas @jquerybot